Merge branch 'main' into 'main'

fix for TControl.GetDefaultColor never recursing up to parent

See merge request freepascal.org/lazarus/lazarus!452

lcl/dialogs.pp

@@ -184,9 +184,9 @@ type
   { TOpenDialog }
   
   TOpenOption = (
-    ofReadOnly,            // Include read-only files.
+    ofReadOnly,            // Causes the Read Only check box to be selected initially when the dialog box is created. This flag indicates the state of the Read Only check box when the dialog box is closed.
     ofOverwritePrompt,     // If selected file exists show a message, that file will be overwritten.
-    ofHideReadOnly,        // Hide read-only file.
+    ofHideReadOnly,        // Hides the Read Only check box.
     ofNoChangeDir,         // Do not change current directory.
     ofShowHelp,            // Show a help button.
     ofNoValidate,          // Disable file name validation using OFN_NOVALIDATE on the Windows platform. Allow file names with invalid characters.

lcl/include/control.inc

@@ -1434,11 +1434,10 @@ const
   );
 begin
   Result := TWSControlClass(WidgetSetClass).GetDefaultColor(Self, DefaultColorType);
-  if (Result = clDefault) then
-    if ParentColor and Assigned(Parent) then
-      Result := Parent.GetDefaultColor(DefaultColorType)
+  if (Self.Color = clDefault) and ParentColor and Assigned(Parent) then
+      Result := Parent.GetDefaultColor(DefaultColorType)                      // recursion
     else
-      Result := DefColors[DefaultColorType];
+      if Result = clDefault then Result := DefColors[DefaultColorType];       // backstop
 end;
 
 function TControl.GetColorResolvingParent: TColor;

lcl/include/inputdialog.inc

@@ -81,6 +81,7 @@ begin
       Parent := Form;
       ShowBevel := False;
       ShowButtons := [pbOK, pbCancel];
+      Color:=Parent.GetDefaultColor(dctBrush);   // fix for wrong background colour
       Align := alTop;
     end;