paweld/lazarus
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/lazarus/lazarus.git synced 2025-08-17 01:29:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

cocoa: menus - fix cocoa app mem leak for allocated TcocoaMenuItems

Browse Source 
git-svn-id: trunk@59754 -
This commit is contained in:
dmitry 2018-12-07 04:04:18 +00:00
parent 480574f3d9
commit 360bfc74b1
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lcl/interfaces/cocoa/cocoawsmenus.pas
View File

@ -588,10 +588,12 @@ begin
if Assigned(menuitem.menu) then
menuitem.menu.removeItem(menuitem);
AMenuItem.Handle := 0;
menuitem.release; // TCocoaMenuItems are "alloced" - thus should be released;
end else if item.isKindOfClass_(NSMenuItem) then begin
nsitem := NSMenuItem(item);
if nsitem.isSeparatorItem and Assigned(nsitem.menu) then
nsitem.menu.removeItem(nsitem);
// separator items are not "alloced", thus should not be released
end;
end;